Response getter for WebApiExtension #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm -1 for adding a getter for this, as it would mean that the type of the Response becomes part of our API, and we cannot support Guzzle6 anymore (see #35) |
|
I understand that you want to be able to perform more assertions, but we first need to find the right architecture to expose things without making the maintenance a BC nightmare |
|
+1 for this. See my comment at #40 |
|
Now that #35 was merged, can we come back to this issue? Making the response accessible in a subclass is really hacky at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add more step definitions, by extending the WebApiContext class, we need access to the response object. By default, the response property is defined with "private" visibility. We either need a getter or the visibility to be changed to protected. To keep the consistency, lets add a getter method.